Skip to content
This repository was archived by the owner on Mar 11, 2022. It is now read-only.

Dbinfo sizes#503

Merged
ricellis merged 1 commit intomasterfrom
dbinfo-sizes
Feb 18, 2020
Merged

Dbinfo sizes#503
ricellis merged 1 commit intomasterfrom
dbinfo-sizes

Conversation

@ricellis
Copy link
Copy Markdown
Member

@ricellis ricellis commented Feb 18, 2020

Checklist

  • Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
  • Added tests for code changes or test/build only changes
  • Updated the change log file (CHANGES.md|CHANGELOG.md) or test/build only changes
  • Completed the PR template below:

Description

Updated DbInfo sizes functionality.

1. Steps to reproduce and the simplest code sample possible to demonstrate the issue

Call db.info().getDiskSize() on CouchDB 3

2. What you expected to happen

Expected to get the actual disk size.

3. What actually happened

Got 0.

Approach

  • Added DbInfo#getSizes() for access to improved sizes information from newer Couch releases.
  • Corrected existing DbInfo#getDiskSize() to work with sizes object if disk_size is unavailable.

Schema & API Changes

  • Added new API model DbInfo.Sizes

Security and Privacy

  • "No change"

Testing

  • Added new tests to DbInfoMockTests:
    • getDbInfoDiskSizeZeroWithoutException
    • getDbInfoDiskSize
    • getDbInfoDiskSizeFromSizes
    • getDbInfoSizes

Monitoring and Logging

  • "No change"

@ricellis ricellis added this to the 2.next milestone Feb 18, 2020
@ricellis ricellis self-assigned this Feb 18, 2020
Copy link
Copy Markdown
Contributor

@emlaver emlaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! +1

@ricellis ricellis merged commit fbbedac into master Feb 18, 2020
@ricellis ricellis deleted the dbinfo-sizes branch February 18, 2020 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants